----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19389/#review110831 -----------------------------------------------------------
Could you explain what the motivation for this patch is? >From what I can see, this is making a const reference bind to a temporary >string which is being constructed from `(const) char*`. This doesn't save us any copies and it is also against the Mesos C++ Style Guide. - Michael Park On March 19, 2014, 5:16 a.m., Archana kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19389/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 5:16 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > see summary > > > Diffs > ----- > > src/sasl/authenticatee.hpp 42a4eba > > Diff: https://reviews.apache.org/r/19389/diff/ > > > Testing > ------- > > > Thanks, > > Archana kumari > >
