> On Dec. 15, 2015, 10:18 a.m., Adam B wrote: > > Thanks for validating the expected `--roles` behavior with tests, but I > > think you're mixing up the scheduler reservation/volume API (where only the > > framework's role is valid) with the operator API (where any whitelisted > > role is valid).
Ah, good point! Turns out that we weren't properly enforcing `--roles` for dynamic reservations anyway (see MESOS-4143). I'll remove these tests for now and fix 4143 shortly. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/#review110460 ----------------------------------------------------------- On Dec. 16, 2015, 9:05 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40995/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 9:05 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and > Yongqiao Wang. > > > Repository: mesos > > > Description > ------- > > Added test cases for role behavior. > > > Diffs > ----- > > src/Makefile.am 8f6b98b5b0ddbfe6b97346704cb96937e0eca02e > src/tests/reservation_tests.cpp f429472e6b93a5d6d8fe6a5f7d5b94fc331f7295 > src/tests/role_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/40995/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Neil Conway > >
