----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review110581 -----------------------------------------------------------
docs/containerizer-internals.md (lines 39 - 43) <https://reviews.apache.org/r/39456/#comment170527> This is not true. Composing containerizer will compose the specified containerizers together and act like a single containerizer. docs/containerizer-internals.md (lines 55 - 61) <https://reviews.apache.org/r/39456/#comment170528> I would mention two cases here: 1) User specifies a TaskInfo without an executor 2) User specifies a TaskInfo with an executor The flow of the above 2) is different. Please read the code to understand the difference. docs/containerizer-internals.md (line 72) <https://reviews.apache.org/r/39456/#comment170546> For the executor using Launcher (link to the following section). docs/containerizer-internals.md (line 82) <https://reviews.apache.org/r/39456/#comment170548> I would just add a short summary about Launcher: ``` Launcher is responsible for forking/destroying containers. ``` docs/containerizer-internals.md (lines 83 - 87) <https://reviews.apache.org/r/39456/#comment170549> I would remove this. docs/containerizer-internals.md (lines 86 - 87) <https://reviews.apache.org/r/39456/#comment170547> User is not allowed to set the 'setup' function. docs/containerizer-internals.md (line 94) <https://reviews.apache.org/r/39456/#comment170550> using 'clone' system call - Jie Yu On Dec. 15, 2015, 6:22 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39456/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 6:22 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Documentation: added containerizer internals > > > Diffs > ----- > > docs/containerizer-internals.md PRE-CREATION > docs/home.md a01612ec8347eb8a7a9277b829365b6c3a1fe9e3 > > Diff: https://reviews.apache.org/r/39456/diff/ > > > Testing > ------- > > > Thanks, > > Jojy Varghese > >
