> On Dec. 15, 2015, 11:08 a.m., Adam B wrote: > > include/mesos/v1/mesos.proto, lines 1560-1567 > > <https://reviews.apache.org/r/41187/diff/3/?file=1163915#file1163915line1560> > > > > I agree with Guangya. Could you improve the comment for this protobuf > > message, explaining what protocol and visibility should mean here too?
Agreed. See the latest diff for comments on Port message. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/#review110472 ----------------------------------------------------------- On Dec. 15, 2015, 10:11 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41187/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 10:11 p.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Bugs: MESOS-3962 > https://issues.apache.org/jira/browse/MESOS-3962 > > > Repository: mesos > > > Description > ------- > > Adding labels field to Port information, for service discovery to associate > arbitrary tags by applications to ports for a given task. > > > Diffs > ----- > > include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 > include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 > > Diff: https://reviews.apache.org/r/41187/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Avinash sridharan > >
