----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41236/#review109979 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/puller.cpp (lines 157 - 158) <https://reviews.apache.org/r/41236/#comment169717> I find it easier to read when the closing ' is on the same line, for example: ``` return Failure("Failed to create rootfs path '" + localRootfsPath + "'" + ": " + mkdir.error()); ``` src/slave/containerizer/mesos/provisioner/docker/puller.cpp (lines 169 - 170) <https://reviews.apache.org/r/41236/#comment169722> This should be a 4 space indent rather than 2, but why bother wrapping on the next line? Looks like both styles are ok here, so I assume you're going for consistency with the code in this area. - Ben Mahler On Dec. 11, 2015, 2:01 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41236/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2015, 2:01 a.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and > Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Some consistency style fixes in Docker puller. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > 4aa4a9c4074d96c30c3bceea59d071feeecae2ea > > Diff: https://reviews.apache.org/r/41236/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
