----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/#review109543 -----------------------------------------------------------
src/slave/cmake/FindCurl.cmake (line 18) <https://reviews.apache.org/r/41090/#comment169107> This looks like it was copied from `FindApr`, so it seems like it might make sense to make the comment reflect that instead. src/slave/cmake/FindCurl.cmake (line 50) <https://reviews.apache.org/r/41090/#comment169105> If there is only one name we're looking for, and we're only using it in `find_library`, does it make sense to just remove the variable and put it below? src/slave/cmake/FindCurl.cmake (lines 108 - 109) <https://reviews.apache.org/r/41090/#comment169106> Interestingly, the comment suggests that we're exporting `CURL_LIBS` but not `CURL_LIB`, but this seems to be doing the opposite. I do notice that we do this also in `FindApr.cmake`, too, though, which also seems like a mistake (but I don't remember my thought process at the time). So, it seems like it's worth looking at which we're _actually_ exporting, and which we _meant_ to export, and writing comments that reflect those. Because, if this comment is to be believed, we are exporting basically the wrong variables. - Alex Clemmer On Dec. 9, 2015, 3:45 a.m., Diana Arroyo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41090/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 3:45 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > ------- > > Second iteration of changes for cmake build on linux. > > > Diffs > ----- > > src/slave/cmake/FindCurl.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/41090/diff/ > > > Testing > ------- > > Tested on Ubuntu and OSX. > > > Thanks, > > Diana Arroyo > >
