----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review109203 -----------------------------------------------------------
3rdparty/libprocess/include/process/process.hpp (lines 261 - 263) <https://reviews.apache.org/r/38000/#comment168678> I'm not sure how the comment is related to the typedef. Do you mean one of the parameter is `principal`? Mind explaining it then? 3rdparty/libprocess/include/process/process.hpp (line 264) <https://reviews.apache.org/r/38000/#comment168682> Given the second argument is optional (and assuming it's principal), I believe `AuthenticatedHttpRequestHandler` may also be responsible for requests that do not require authentication (e.g. no authenticator for the realm). If my understanding is correct, naming the handler with `Authenticated*` can be misleading. 3rdparty/libprocess/src/process.cpp (lines 3218 - 3220) <https://reviews.apache.org/r/38000/#comment168691> If this is an internal invariant, how about adding a `CHECK` here? 3rdparty/libprocess/src/tests/http_tests.cpp (lines 20 - 23) <https://reviews.apache.org/r/38000/#comment168693> Sort alphabetically 3rdparty/libprocess/src/tests/http_tests.cpp (lines 1314 - 1315) <https://reviews.apache.org/r/38000/#comment168694> Blank line or swap. 3rdparty/libprocess/src/tests/http_tests.cpp (lines 1357 - 1358) <https://reviews.apache.org/r/38000/#comment168696> Blank line or swap. 3rdparty/libprocess/src/tests/http_tests.cpp (line 1373) <https://reviews.apache.org/r/38000/#comment168698> Let's definitely have a comment here why there is sleep. Also, why not `os::sleep()`? - Alexander Rukletsov On Dec. 7, 2015, 2:14 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38000/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 2:14 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-3233 > https://issues.apache.org/jira/browse/MESOS-3233 > > > Repository: mesos > > > Description > ------- > > Adds functions which allow libprocess users to register HTTP authenticators. > Overloads `ProcesBase::route()` to allow for registering of authenticating > endpoints. > Includes tests. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/event.hpp > a03824c061c4a0eb865b163999a763635e56744c > 3rdparty/libprocess/include/process/process.hpp > 81c094414d4d5ac5eb593df2a6d14aaacb19a826 > 3rdparty/libprocess/src/process.cpp > e93709d3bb4ac588457bb9331fc05ec5ab539f6d > 3rdparty/libprocess/src/tests/http_tests.cpp > 2de75ca1c7e224c36b534c368e7379dc158aa5bb > > Diff: https://reviews.apache.org/r/38000/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
