----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40941/#review108916 -----------------------------------------------------------
Ship it! src/hdfs/hdfs.cpp (line 52) <https://reviews.apache.org/r/40941/#comment168374> Add a TODO to eventually move this to subprocess? src/hdfs/hdfs.cpp (lines 55 - 56) <https://reviews.apache.org/r/40941/#comment168373> instead of CHECKs why not return failed futures? - Vinod Kone On Dec. 4, 2015, 12:04 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40941/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 12:04 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added a helper for HDFS client to shell out commands. > > Code is copied from https://reviews.apache.org/r/40559/. > > > Diffs > ----- > > src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b > > Diff: https://reviews.apache.org/r/40941/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
