> On Dec. 3, 2015, 1:40 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1026 > > <https://reviews.apache.org/r/40551/diff/5/?file=1148500#file1148500line1026> > > > > roleConsumedResources = roleConsumedResources.nonRevocable();
As you may know, `.nonRevocable()` filter landed rather recently, far later than this patch has been proposed. Right after, [a follow-up patch](https://reviews.apache.org/r/40821/) has been published for review and is part of the current chain. Applying `.nonRevocable()` filter required a more careful approach, otherwise we may blindly apply it to resources that do not contain revocable resources by default. Please review [that patch](https://reviews.apache.org/r/40821/) instead. Same for similar comments below. > On Dec. 3, 2015, 1:40 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1054 > > <https://reviews.apache.org/r/40551/diff/5/?file=1148500#file1148500line1054> > > > > user nonRevocable()? See above. > On Dec. 3, 2015, 1:40 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1116 > > <https://reviews.apache.org/r/40551/diff/5/?file=1148500#file1148500line1116> > > > > use nonRevocable() directly? See above. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40551/#review108817 ----------------------------------------------------------- On Nov. 30, 2015, 3:24 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40551/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2015, 3:24 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Qian Zhang. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > ------- > > Quota is satisfied in a separate loop over agents. Running total is > maintained as an exit criterion for the WDRF allocation stage. > > Precursory version: https://reviews.apache.org/r/39401/ > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 31ed62efb5b1a2edb567f43d37559c5914e0665e > > Diff: https://reviews.apache.org/r/40551/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
