----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40118/#review108798 -----------------------------------------------------------
include/mesos/mesos.proto (lines 629 - 631) <https://reviews.apache.org/r/40118/#comment168278> Let's leave a note why it's marked `optional`, which is inconsistent to `ReservationInfo.principal`. For symmetry, maybe it makes sense to add a `TODO` around `ReservationInfo.principal` that we may change it to optional as well - Alexander Rukletsov On Dec. 2, 2015, 9:42 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40118/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 9:42 a.m.) > > > Review request for mesos, Jie Yu, Michael Park, and Neil Conway. > > > Bugs: MESOS-3064 > https://issues.apache.org/jira/browse/MESOS-3064 > > > Repository: mesos > > > Description > ------- > > Added 'principal' field to 'Resource.DiskInfo.Persistence'. > > > Diffs > ----- > > include/mesos/mesos.proto 27971fea6935b82d7034397edaa7a37edb1f6f38 > include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd > > Diff: https://reviews.apache.org/r/40118/diff/ > > > Testing > ------- > > This is the first in a chain of 7 patches. `make check` was used to test > after all patches were applied. > > Note that this chain of patches touches many of the same files as another > chain beginning with Review #39985 and ending with Review #39989, which is > currently in review as well. To avoid conflicts, the beginning of this chain > begins on top of Review #39989. > > One additional patch with documentation is forthcoming. > > > Thanks, > > Greg Mann > >
