----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40732/#review108141 -----------------------------------------------------------
I don't think we're ready to enable this test yet. The test is checking that `operator==` for `Resources` tolerates floating-point roundoff error -- but it doesn't, yet. (Changing the test to use CHECK_DOUBLE_EQ() changes what is being tested.) src/tests/resources_tests.cpp (line 1526) <https://reviews.apache.org/r/40732/#comment167493> If we're going to enable this test, the comment should be removed. - Neil Conway On Nov. 26, 2015, 6:52 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40732/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 6:52 a.m.) > > > Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway. > > > Bugs: MESOS-3552 > https://issues.apache.org/jira/browse/MESOS-3552 > > > Repository: mesos > > > Description > ------- > > This is an existing test case to check precision of resource reservations, > but would have always failed due to double precision errors. Forcing the test > case to use EXPECT_DOUBE_EQ instead of EXPECT_EQ (strict equality) > > > Diffs > ----- > > src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 > > Diff: https://reviews.apache.org/r/40732/diff/ > > > Testing > ------- > > Ran make check against 40730 > > > Thanks, > > Avinash sridharan > >
