----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108142 -----------------------------------------------------------
src/tests/reservation_tests.cpp (line 163) <https://reviews.apache.org/r/40731/#comment167494> In Mesos, we use two blank lines to separate function definitions. src/tests/reservation_tests.cpp (line 176) <https://reviews.apache.org/r/40731/#comment167496> The whitespace is wrong here: Mesos uses an indentation offset of 2 spaces, not 8. For more on the style requirements, see https://mesos.apache.org/documentation/latest/c++-style-guide/ - Neil Conway On Nov. 26, 2015, 6:52 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40731/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 6:52 a.m.) > > > Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway. > > > Bugs: 3552 > https://issues.apache.org/jira/browse/3552 > > > Repository: mesos > > > Description > ------- > > Adding the test framework submitted by Mandeep (@mchadha) > https://reviews.apache.org/r/39056/ > > > Diffs > ----- > > src/tests/reservation_tests.cpp 15d180f92ec0aea99e6f3a7d0b505c62bd207b61 > > Diff: https://reviews.apache.org/r/40731/diff/ > > > Testing > ------- > > Ran make check after adding Mandeep's test case to the GTEST framework. > > > Thanks, > > Avinash sridharan > >
