> On Nov. 23, 2015, 8:43 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 387 > > <https://reviews.apache.org/r/40544/diff/2/?file=1135399#file1135399line387> > > > > I think we need to check if the role is known by master just like what > > we did for set quota, and also need to add a TODO to state that we should > > remove this check once we are able to dynamically add roles.
I agree with the check in the master, as that is slightly different from the implied check currently being relied on (that a quota is set for that role). I disagree on the TODO. I don't think it makes sense to remove this check once dynamic roles are introduced, as removing quota for a role doesn't seem to make sense for a role that doesn't exist, even in a dynamic role world. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/#review107565 ----------------------------------------------------------- On Nov. 25, 2015, 9:26 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40544/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 9:26 p.m.) > > > Review request for mesos, Alexander Rukletsov and Joris Van Remoortere. > > > Bugs: MESOS-4014 > https://issues.apache.org/jira/browse/MESOS-4014 > > > Repository: mesos > > > Description > ------- > > Added quota remove handling. > > > Diffs > ----- > > src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 > src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f > > Diff: https://reviews.apache.org/r/40544/diff/ > > > Testing > ------- > > Test are in the next review. > > > Thanks, > > Joerg Schad > >
