> On Nov. 10, 2015, 4:03 p.m., Joerg Schad wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1151 > > <https://reviews.apache.org/r/39450/diff/6/?file=1113990#file1113990line1151> > > > > Also the simple case of correct behavior with several frameworks in one > > role would be interesting.
DO you mean something like `MultipleFrameworksInRoleWithQuota`, L1370? > On Nov. 10, 2015, 4:03 p.m., Joerg Schad wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1174 > > <https://reviews.apache.org/r/39450/diff/6/?file=1113990#file1113990line1174> > > > > Does it make sense to refelect that in the role name? Good idea! > On Nov. 10, 2015, 4:03 p.m., Joerg Schad wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1619 > > <https://reviews.apache.org/r/39450/diff/6/?file=1113990#file1113990line1619> > > > > This describes more the user story, should we maybe focus on what the > > test itself intends to test? I'd say, the test intends to test exactly this user story : ). For me it's easier to understand the purpose of the test if I know the background or the issue. Because this test is not trivial, I would argue the user story helps. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/#review105885 ----------------------------------------------------------- On Nov. 23, 2015, 10:45 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39450/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 10:45 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3984 > https://issues.apache.org/jira/browse/MESOS-3984 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 740cfa801ee90417c038308192d1f4f2416f8315 > > Diff: https://reviews.apache.org/r/39450/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
