> On Nov. 18, 2015, 4:56 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 224 > > <https://reviews.apache.org/r/40392/diff/2/?file=1128686#file1128686line224> > > > > I'm a bit concerned whether it's a good solution to put this flag in > > the request body. I'd say better alternatives are: > > - A single JSON object per request (with the `force` flag inside); > > - `force` flag in the URL. > > > > What do you think?
see answer in my my review below. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107041 ----------------------------------------------------------- On Nov. 17, 2015, 5:38 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40392/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 5:38 p.m.) > > > Review request for mesos, Alexander Rukletsov and Joris Van Remoortere. > > > Bugs: MESOS-3911 > https://issues.apache.org/jira/browse/MESOS-3911 > > > Repository: mesos > > > Description > ------- > > Added force flag to override quota capacityHeuristic check. > > > Diffs > ----- > > src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/40392/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Joerg Schad > >
