----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107080 -----------------------------------------------------------
Looks good! Just a few small suggestions and comments. src/master/http.cpp (line 612) <https://reviews.apache.org/r/40247/#comment166009> Just a note that the signature of `_operation` will change to include a boolean `authorized` parameter when the authorization patches merge; depending on which patches land first, we can address it as necessary. src/master/http.cpp (line 699) <https://reviews.apache.org/r/40247/#comment166007> Ditto regarding the `_operation()` signature. src/tests/mesos.hpp (line 513) <https://reviews.apache.org/r/40247/#comment166008> s/if and only the/if and only if the/ src/tests/persistent_volume_endpoints_tests.cpp (lines 498 - 500) <https://reviews.apache.org/r/40247/#comment166029> Is this behavior significant enough to create a JIRA to evaulate and possibly change it? src/tests/persistent_volume_endpoints_tests.cpp (lines 655 - 657) <https://reviews.apache.org/r/40247/#comment166030> Perhaps it's overkill for a mangled request like this, but I wonder if this test should go into a case that provides a successfully-created volume that could potentially be destroyed? src/tests/persistent_volume_endpoints_tests.cpp (lines 690 - 692) <https://reviews.apache.org/r/40247/#comment166031> Ditto, like the `destroy-volume` request above. - Greg Mann On Nov. 18, 2015, 11:28 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40247/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 11:28 a.m.) > > > Review request for mesos, Greg Mann and Michael Park. > > > Bugs: MESOS-2455 > https://issues.apache.org/jira/browse/MESOS-2455 > > > Repository: mesos > > > Description > ------- > > Added HTTP endpoints for creating and destroying persistent volumes. > > > Diffs > ----- > > docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 > docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a > src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 > src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 > src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 > src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 > src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b > src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/40247/diff/ > > > Testing > ------- > > (1) make check, including newly added tests > > (2) Manually created/removed persistent volumes via HTTP endpoints + curl. > > (3) Previewed docs in Github gist. > > > Thanks, > > Neil Conway > >
