----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40244/#review106992 -----------------------------------------------------------
src/master/http.cpp (line 2096) <https://reviews.apache.org/r/40244/#comment165872> This comment may not be related to this patch. I am just curious, for ```required```, we have called ```flatten()``` to remove role from it when passing it into ```Master::Http::_operation()```. But here for ```offer->resources()```, we do not call ```flatten()``` to remove its role, so is it subtractable between ```required``` and ```offer->resources()```? - Qian Zhang On Nov. 13, 2015, 8:45 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40244/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 8:45 p.m.) > > > Review request for mesos, Greg Mann and Michael Park. > > > Bugs: MESOS-2455 > https://issues.apache.org/jira/browse/MESOS-2455 > > > Repository: mesos > > > Description > ------- > > Clarified comments in Master::Http::_operation. > > > Diffs > ----- > > src/master/http.cpp f4ec23d74e203b2a8f2af187f0e56fbde7d9b3e5 > > Diff: https://reviews.apache.org/r/40244/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
