> On Nov. 18, 2015, 2:11 a.m., Vinod Kone wrote: > > include/mesos/mesos.proto, line 651 > > <https://reviews.apache.org/r/40375/diff/1/?file=1127795#file1127795line651> > > > > I don't think adding a required field to a protobuf that is sent across > > the wire is backwards compatible. This should be optional with default as > > USAGE_SLACK.
Agree; we should keep backwards compatible. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review106898 ----------------------------------------------------------- On Nov. 17, 2015, 11:30 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40375/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 11:30 a.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van > Remoortere. > > > Bugs: MESOS-3888 > https://issues.apache.org/jira/browse/MESOS-3888 > > > Repository: mesos > > > Description > ------- > > MESOS-3888: We need to distinguish revocable resource for usage slack and > allocation slack. > > > Diffs > ----- > > include/mesos/mesos.proto 5ad48bd > > Diff: https://reviews.apache.org/r/40375/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Klaus Ma > >
