> On Oct. 19, 2015, 10:21 p.m., Joerg Schad wrote: > > src/tests/master_quota_tests.cpp, line 139 > > <https://reviews.apache.org/r/38956/diff/5/?file=1098313#file1098313line139> > > > > Is there a reason to repeat 'protected:' here > > Alexander Rukletsov wrote: > It separates methods section from fields. We are inconsitent, see for > example `HierarchicalAllocatorTestBase`, `PortMappingIsolatorTest`.
I will leave the extra `protected` because it doesn't hurt and it's self documenting code. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/#review103175 ----------------------------------------------------------- On Nov. 14, 2015, 3:46 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38956/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2015, 3:46 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Michael Park. > > > Bugs: MESOS-3720 > https://issues.apache.org/jira/browse/MESOS-3720 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38956/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
