> On Nov. 15, 2015, 3:50 p.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, lines 117-118
> > <https://reviews.apache.org/r/38110/diff/15/?file=1125721#file1125721line117>
> >
> > This is a great comment. Can you also make it clear why we actually
> > want to account for them?
Do you mean something like:
```
// In contrast to static
// reservations, dynamic reservations may be unreserved at any time,
// hence making resources available for quota'ed framewroks.
```
> On Nov. 15, 2015, 3:50 p.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, line 119
> > <https://reviews.apache.org/r/38110/diff/15/?file=1125721#file1125721line119>
> >
> > Then we can rename this to `nonStaticAgentResources`. It might be so
> > clear we can remove the first line of the comment above! :-)
A very good proposal, thanks!
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/#review106560
-----------------------------------------------------------
On Nov. 14, 2015, 3:44 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38110/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2015, 3:44 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere,
> Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-3074
> https://issues.apache.org/jira/browse/MESOS-3074
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Performs a check whether a quota request is reasonable and can be satisfied
> at the moment. A precise answer is impossible here, but a sanity check is
> still helpful, because it allows us to filter knowingly unsatisfiable
> requests.
>
>
> Diffs
> -----
>
> src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2
> src/master/quota_handler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38110/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
