> On Nov. 11, 2015, 7:55 a.m., Joris Van Remoortere wrote: > > src/master/quota_handler.cpp, lines 67-87 > > <https://reviews.apache.org/r/39285/diff/18/?file=1122095#file1122095line67> > > > > How come we don't leverage the validation routine you introduced in > > this patch here?
As the validation routine expects a QuotaInfo object (as it could also verify general QuotaInfo objects) and at this point we are just creating this QuotaInfo object. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review105803 ----------------------------------------------------------- On Nov. 10, 2015, 6:20 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 6:20 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > ------- > > Added Quota Request Validation. > > > Diffs > ----- > > src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 > src/master/quota.hpp PRE-CREATION > src/master/quota.cpp PRE-CREATION > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > ------- > > make test > > > Thanks, > > Joerg Schad > >
