> On Oct. 6, 2015, 12:40 p.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, line 60 > > <https://reviews.apache.org/r/38059/diff/3/?file=1088987#file1088987line60> > > > > I think that this function is mainly doing getQuoteRequest()? > > Alexander Rukletsov wrote: > Converting JSON to protobuf is not a big deal, I wanted to put the accent > on the validation checks. > > Guangya Liu wrote: > Can we split this to two functions, one is validataQuotaRequest and the > other is getQuotaRequest? > > Joerg Schad wrote: > Constructing the protobuf is part of the basic checks and from my point > it feels ok that validates return the protobuf.
We revisited the design and I think we addressed this issue in the next review. I'll drop it here, please check the next patch in the chain and comment there in case you feel like. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/#review101638 ----------------------------------------------------------- On Nov. 9, 2015, 11:14 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38059/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 11:14 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3073 > https://issues.apache.org/jira/browse/MESOS-3073 > > > Repository: mesos > > > Description > ------- > > Processing quota request consists of several stages: request validation, > sanity check and so on. This patch creates a basic workflow for quota > requests, while the stages are implemented in subsequent patches. > > > Diffs > ----- > > src/CMakeLists.txt f6ae05d4652df6de98a9e110efed87f7fcbd29f9 > src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 > src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 > src/master/quota.hpp PRE-CREATION > src/master/quota.cpp PRE-CREATION > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38059/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
