----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105824 -----------------------------------------------------------
src/slave/containerizer/fetcher.hpp (line 252) <https://reviews.apache.org/r/39595/#comment164499> Not yours, but this function can probably be const. src/slave/containerizer/fetcher.cpp (line 247) <https://reviews.apache.org/r/39595/#comment164501> Newline after "(" to reduce jaggedness. src/slave/containerizer/fetcher.cpp (line 262) <https://reviews.apache.org/r/39595/#comment164502> Newline after this line please. src/slave/containerizer/fetcher.cpp (line 934) <https://reviews.apache.org/r/39595/#comment164512> 4 spaces instead of 2 spaces. src/slave/containerizer/fetcher.cpp (line 972) <https://reviews.apache.org/r/39595/#comment164497> Function can be made const. - Jan Schlicht On Nov. 6, 2015, 8:52 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39595/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2015, 8:52 p.m.) > > > Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. > > > Bugs: MESOS-3785 > https://issues.apache.org/jira/browse/MESOS-3785 > > > Repository: mesos > > > Description > ------- > > Also added function to query mtime of HDFS resource. > > > Diffs > ----- > > src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba > src/slave/containerizer/fetcher.hpp > c7518a36f6344841880dbb11bfce603fd2791fc0 > src/slave/containerizer/fetcher.cpp > e0d02d5f8f4f6e930a2ae6abe365548af6d1b01f > src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b > > Diff: https://reviews.apache.org/r/39595/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
