----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38874/#review105765 -----------------------------------------------------------
src/slave/slave.hpp (line 679) <https://reviews.apache.org/r/38874/#comment164399> I would avoid using 'Agent' for now in the code (except the v1 API). Constantly switching between 'agent' and 'slave' is not good for readability. src/slave/slave.cpp (line 5166) <https://reviews.apache.org/r/38874/#comment164397> Do you want to change that as well? - Jie Yu On Oct. 23, 2015, 1:34 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38874/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 1:34 a.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Bugs: MESOS-3480 > https://issues.apache.org/jira/browse/MESOS-3480 > > > Repository: mesos > > > Description > ------- > > This change refactors the Executor struct on Agent and adds support for > Executors to connect via the `api/v1/executor` endpoint on Agent. This is > similar to the change done in Master for the Scheduler HTTP API. > > > Diffs > ----- > > src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 > src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a > > Diff: https://reviews.apache.org/r/38874/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
