> On Nov. 6, 2015, 4:22 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp, line 34 > > <https://reviews.apache.org/r/39944/diff/3/?file=1116598#file1116598line34> > > > > I'm not opposed to include this, I just hope we include some context > > why we need this. > > > > I'm assuming you want to fix the problem of environment variables with > > docker containers around SSL_*. > > > > I think as you mentinoed, having to keep up with new ones we add is a > > pain, but at the same time accidentially including environment variables I > > believe causing more headaches since SSL_ or other regex can potentially > > match things that production systems don't want to be including.
hmm, let me discard this and create a patch which excalty include environment variables. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39944/#review105444 ----------------------------------------------------------- On Nov. 5, 2015, 8:25 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39944/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 8:25 a.m.) > > > Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen. > > > Bugs: MESOS-3815 > https://issues.apache.org/jira/browse/MESOS-3815 > > > Repository: mesos > > > Description > ------- > > Add prefix option for os::environment. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp > 91d82a8fae27c002458cad0bbdc45b312d2ec70d > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff > > Diff: https://reviews.apache.org/r/39944/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
