> On Nov. 6, 2015, 4:06 p.m., Joerg Schad wrote: > > src/tests/master_quota_tests.cpp, line 170 > > <https://reviews.apache.org/r/38956/diff/8/?file=1114104#file1114104line170> > > > > Also we usually use 3rd person in test comments. > > (see your comment on 39223) > > > > > > // This test ensures... > > > > or > > > > // This tests that... > > > > or simply > > > > // Tests whether...
What I was trying to ask was whether we should use Tests instead of Verfies.... - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/#review105438 ----------------------------------------------------------- On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38956/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 7:27 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Michael Park. > > > Bugs: MESOS-3720 > https://issues.apache.org/jira/browse/MESOS-3720 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 > src/master/quota_handler.cpp PRE-CREATION > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38956/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
