----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review105313 -----------------------------------------------------------
src/master/quota_handler.cpp (lines 93 - 101) <https://reviews.apache.org/r/39285/#comment163833> What do you think about using helpers from `include/mesos/resources.hpp`? A bunch of these checks could be done on a `Resources` (plural) object. src/master/quota_handler.cpp (lines 151 - 152) <https://reviews.apache.org/r/39285/#comment163835> Can you comment that this is guaranteed by the master? - Joseph Wu On Oct. 24, 2015, 12:42 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2015, 12:42 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > ------- > > Added Quota Request Validation. > > > Diffs > ----- > > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > ------- > > > Thanks, > > Joerg Schad > >
