----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/#review104775 -----------------------------------------------------------
Ship it! Double-checked non-Windows builds. - Joseph Wu On Oct. 29, 2015, 10:58 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39623/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 10:58 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > CMake: Added protobuf compilation to Windows builds. > > > Diffs > ----- > > src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 > > Diff: https://reviews.apache.org/r/39623/diff/ > > > Testing > ------- > > `make check` from CMake on OS X 10.10. > `make check` from Autotools on OS X 10.10. > Ran `check` project in VS on Windows 10. > > PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH > into my Ubuntu box to test this from Ubuntu > > > Thanks, > > Alex Clemmer > >
