----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review104090 -----------------------------------------------------------
Note: considering the amount of changes since my last review, my "Ship It" is no longer valid. support/apply-reviews.py (line 15) <https://reviews.apache.org/r/38705/#comment162307> This won't work on Windows, since it'll construct "URL"s with (evil) backslashes. (And considering how often we use this script for the CMake/Windows review chains... :) This would be better: https://docs.python.org/2/library/urlparse.html#urlparse.urljoin support/apply-reviews.py (line 38) <https://reviews.apache.org/r/38705/#comment162310> Nit: Extra space after the if. support/apply-reviews.py (line 78) <https://reviews.apache.org/r/38705/#comment162313> Nit: Extra space after function name. - Joseph Wu On Oct. 22, 2015, 11:16 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38705/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 11:16 p.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, > and Vinod Kone. > > > Bugs: MESOS-3468 > https://issues.apache.org/jira/browse/MESOS-3468 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/apply-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/38705/diff/ > > > Testing > ------- > > Tested the script with python 2.7. > > > Thanks, > > Artem Harutyunyan > >
