> On Oct. 23, 2015, 4:49 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 270-274 > > <https://reviews.apache.org/r/39539/diff/1/?file=1103030#file1103030line270> > > > > Do you need this one?
There are some uses of `os::mktemp` in the code-base. > On Oct. 23, 2015, 4:49 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 280-284 > > <https://reviews.apache.org/r/39539/diff/1/?file=1103030#file1103030line280> > > > > Why is this function body different than all the other alias-like > > functions? > > > > i.e. You could comment that stout/mktemp needs an open file, or similar. Agree with Joseph. This is not obvious, had to look at the documentation for linux's mkstemp(). - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39539/#review103793 ----------------------------------------------------------- On Oct. 22, 2015, 3:35 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39539/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 3:35 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3441 > https://issues.apache.org/jira/browse/MESOS-3441 > > > Repository: mesos > > > Description > ------- > > Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > ba2836a72ceee948cb43364e80ada9f132f33d04 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 7f70c9ea7d57634b5bfd40523ba37561ec92a09a > 3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 7a8819541506f57f70a9b577dc97a76fc26ebaa8 > > Diff: https://reviews.apache.org/r/39539/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
