----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39455/#review103160 -----------------------------------------------------------
3rdparty/libprocess/README.md (line 49) <https://reviews.apache.org/r/39455/#comment161126> Space after "process". 3rdparty/libprocess/README.md (line 77) <https://reviews.apache.org/r/39455/#comment161121> All on one line? 3rdparty/libprocess/README.md (line 99) <https://reviews.apache.org/r/39455/#comment161120> We are "using namespace process;", so process:: prefix is unnecessary. 3rdparty/libprocess/README.md (line 102) <https://reviews.apache.org/r/39455/#comment161123> Probably should return a value, although not required by C++. 3rdparty/libprocess/README.md (line 107) <https://reviews.apache.org/r/39455/#comment161122> Should we use EXPECT_TRUE / ASSERT_TRUE instead? 3rdparty/libprocess/README.md (line 116) <https://reviews.apache.org/r/39455/#comment161124> Link to dispatch? - Neil Conway On Oct. 19, 2015, 9:17 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39455/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 9:17 p.m.) > > > Review request for mesos, Benjamin Hindman, Greg Mann, and Neil Conway. > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d > > Diff: https://reviews.apache.org/r/39455/diff/ > > > Testing > ------- > > https://gist.github.com/hatred/76a7619ba7b892dd0542 > > > Thanks, > > Anand Mazumdar > >
