----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39265/#review103067 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (lines 92 - 93) <https://reviews.apache.org/r/39265/#comment160926> why is this pulled out by itself? 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp (line 17) <https://reviews.apache.org/r/39265/#comment160927> `string` - Joris Van Remoortere On Oct. 13, 2015, 6:37 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39265/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 6:37 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Move `os::environment` to its own file. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 9e9c3119ad18f4cbc70c70095c71dc4fd19553df > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 5141c1369af60afd6cd5c70c6295d575ea960a83 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/39265/diff/ > > > Testing > ------- > > `make check` on Ubuntu 15, OS X 10.10, and running the `check` project on > Windows 10. > > > Thanks, > > Alex Clemmer > >
