> On 十月 15, 2015, 6:38 p.m., Vinod Kone wrote: > > src/tests/status_update_manager_tests.cpp, line 844 > > <https://reviews.apache.org/r/38051/diff/4/?file=1083944#file1083944line844> > > > > new line.
Do you mean to add an another new line? I found two new lines are added before all functions in this test file, so I add an another new line before this function. - Yong Qiao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review102731 ----------------------------------------------------------- On 十月 16, 2015, 2:36 a.m., Yong Qiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38051/ > ----------------------------------------------------------- > > (Updated 十月 16, 2015, 2:36 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2864 > https://issues.apache.org/jira/browse/MESOS-2864 > > > Repository: mesos > > > Description > ------- > > Only update the task status when its old status is not terminal. > > > Diffs > ----- > > src/master/master.cpp ba12a83 > src/tests/status_update_manager_tests.cpp 9970d71 > > Diff: https://reviews.apache.org/r/38051/diff/ > > > Testing > ------- > > UT: > 1. Write a test for this change. > 2. make successfully! > 3. make check successfully! > 4. Run test framework successfully! > > > Thanks, > > Yong Qiao Wang > >
