> On Oct. 13, 2015, 12:54 a.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/include/process/digest.hpp, line 71 > > <https://reviews.apache.org/r/38747/diff/14/?file=1092722#file1092722line71> > > > > I imagine `fn` is expensive, after all, it's cryptography. :) > > > > Serially doing read and compute seems to be suboptimal but I simply > > parallelize read and compute can cause OOM when read is faster than > > compute. Of couse this is a classic producer and consumer problem and we > > can use a queue. We probably don't want to make things too complicated here > > in a single review but again, this is the issue of reimplemting a generic > > and widely used utility: we don't get to leverage state of the art for > > free... > > > > Just a comment.
Added comment on preliminary performance test. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review102302 ----------------------------------------------------------- On Oct. 13, 2015, 7:21 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38747/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 7:21 p.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added SHA256, SHA512 implementation. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am eb7393904988afc0bc5e9f7dadd545e0d6c04e5f > 3rdparty/libprocess/include/Makefile.am > fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e > 3rdparty/libprocess/include/process/digest.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/CMakeLists.txt > a14b5b8fe22d3e75bef3c716ae7865ddaf132927 > 3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38747/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
