----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/#review102420 -----------------------------------------------------------
Ship it! I've committed this with the following minor style fixes! src/tests/credentials_tests.cpp (line 55) <https://reviews.apache.org/r/39098/#comment160058> `s/> >/>>/` src/tests/credentials_tests.cpp (line 61) <https://reviews.apache.org/r/39098/#comment160059> `s/> >/>>/` src/tests/credentials_tests.cpp (line 85) <https://reviews.apache.org/r/39098/#comment160060> `s/const std::string&/std::string/` src/tests/credentials_tests.cpp (line 86) <https://reviews.apache.org/r/39098/#comment160061> newline after this line src/tests/credentials_tests.cpp (line 88) <https://reviews.apache.org/r/39098/#comment160062> 3 space indent => 4 space indent src/tests/credentials_tests.cpp (line 142) <https://reviews.apache.org/r/39098/#comment160063> 3 space indent => 4 space indent src/tests/credentials_tests.cpp (lines 146 - 147) <https://reviews.apache.org/r/39098/#comment160064> Fits in one line. - Michael Park On Oct. 13, 2015, 8:45 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39098/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 8:45 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3560 > https://issues.apache.org/jira/browse/MESOS-3560 > > > Repository: mesos > > > Description > ------- > > When decoding the JSON credential file into the Credential protobuf object, > the 'secret' which is in 'bytes' is mapped into base64 string automatically > by protobuf from JSON. This creates an unintended behavior, forcing users to > encode in base64 their secret when wanting to pass a JSON file to the > --credentials flag. > > > Diffs > ----- > > include/mesos/mesos.proto 4a16be1 > src/examples/java/TestExceptionFramework.java 78720b0 > src/examples/java/TestFramework.java aad94c0 > src/tests/credentials_tests.cpp ced27c4 > > Diff: https://reviews.apache.org/r/39098/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
