----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review101738 -----------------------------------------------------------
src/sched/sched.cpp (line 139) <https://reviews.apache.org/r/39060/#comment159205> Suggest: Increment Master Detector reference count to xxx for url xxx src/sched/sched.cpp (line 156) <https://reviews.apache.org/r/39060/#comment159206> Suggest: Decrement Master Detector reference count to xx for url xxx src/sched/sched.cpp (line 160) <https://reviews.apache.org/r/39060/#comment159207> Suggest: Delete detector xxx for url xxx src/sched/sched.cpp (lines 187 - 189) <https://reviews.apache.org/r/39060/#comment159208> Why not finish this in L121? src/sched/sched.cpp (lines 1804 - 1805) <https://reviews.apache.org/r/39060/#comment159209> string message = "Failed to find master detector for '" + url; The url can be moved to upper line. - Guangya Liu On 十月 6, 2015, 7:54 p.m., Mandeep Chadha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39060/ > ----------------------------------------------------------- > > (Updated 十月 6, 2015, 7:54 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-3595 > https://issues.apache.org/jira/browse/MESOS-3595 > > > Repository: mesos > > > Description > ------- > > If the number of framework created exceeds the lib process > threads then during master failover the zookeeper updates can > cause deadlock. > > > Diffs > ----- > > src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d > > Diff: https://reviews.apache.org/r/39060/diff/ > > > Testing > ------- > > make check successful > Created 100 framework instances on a 24 CPU machine. Master failover detected > by the framework process and continue to work as expected. > > > Thanks, > > Mandeep Chadha > >
