----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review101476 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp (line 241) <https://reviews.apache.org/r/37996/#comment158872> insert blank line above this one 3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp (line 250) <https://reviews.apache.org/r/37996/#comment158871> insert blank line above this one 3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp (line 263) <https://reviews.apache.org/r/37996/#comment158873> s/an/a 3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp (line 273) <https://reviews.apache.org/r/37996/#comment158874> s/an/a 3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp (line 283) <https://reviews.apache.org/r/37996/#comment158875> suggestion: s/visited/visitedNodes or even just "nodes" 3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp (line 328) <https://reviews.apache.org/r/37996/#comment158876> Replace this line with a blank line. This does not "create" a value, and this value is not "default". 3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp (line 330) <https://reviews.apache.org/r/37996/#comment158877> ^blank line 3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp (line 359) <https://reviews.apache.org/r/37996/#comment158878> Let's not update "init", please use a fresh variable "accumulator". 3rdparty/libprocess/3rdparty/stout/tests/inheritancetree_tests.cpp (line 54) <https://reviews.apache.org/r/37996/#comment158879> Please insert blank lines in places like this one. - Bernd Mathiske On Oct. 5, 2015, 7:46 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37996/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 7:46 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-3231 > https://issues.apache.org/jira/browse/MESOS-3231 > > > Repository: mesos > > > Description > ------- > > Introduces the `InheritanceTree` class which allows to create a tree where > nodes can be tag with some property. This property is then inherited by > children nodes. > > Two behaviors are implemented, overriding, i.e. Adding a property to the > child node of another node with a property already will result in the > ancestor property being lost. The second behavior, accumulating, takes a > function and accumulates > properties of all ancestors. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 76e1674e08bbe65a4fdf86731823a61f231d6d12 > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 9e9c3119ad18f4cbc70c70095c71dc4fd19553df > 3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > 94292f8a46ec31bbaf6e52f48109322bbe123f70 > 3rdparty/libprocess/3rdparty/stout/tests/inheritancetree_tests.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/37996/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
