> On Sept. 24, 2015, 5:38 p.m., Joseph Wu wrote: > > support/apply-reviews.py, line 13 > > <https://reviews.apache.org/r/38705/diff/1/?file=1083811#file1083811line13> > > > > Might be cleaner/safer to use urlparse.urljoin for this: > > https://docs.python.org/2/library/urlparse.html#urlparse.urljoin
`urlparse.urljoin` does not seem to do exactly what is needed here. > On Sept. 24, 2015, 5:38 p.m., Joseph Wu wrote: > > support/apply-reviews.py, line 68 > > <https://reviews.apache.org/r/38705/diff/1/?file=1083811#file1083811line68> > > > > Seems like you don't need a `-r` in this case, because we'd only use > > this script for reviewboard. > > > > i.e. s/-r/review/ I have it for compatibility with `apply-review.sh` and also in case we decide to add support for github later. - Artem ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review100505 ----------------------------------------------------------- On Sept. 23, 2015, 9:26 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38705/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 9:26 p.m.) > > > Review request for mesos, Joris Van Remoortere, Joseph Wu, and Vinod Kone. > > > Bugs: MESOS-3468 > https://issues.apache.org/jira/browse/MESOS-3468 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/apply-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/38705/diff/ > > > Testing > ------- > > > Thanks, > > Artem Harutyunyan > >
