> On Sept. 25, 2015, 10:37 a.m., Joris Van Remoortere wrote: > > Can we simplify this by using: > > `os::mktemp` > > `os::stat::inode` to verify the `ino_t`? > > I know the files get removed after the tests finish running; however, if > > you use gtest_repeat this is a really easy way to fill up your temp dir and > > crash :-( > > Can we remove the file explicitly at the end of the test? > > What are your thoughts?
Thank you, Joris! I addressed your comments. - Artem ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38667/#review100626 ----------------------------------------------------------- On Sept. 26, 2015, 12:43 a.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38667/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2015, 12:43 a.m.) > > > Review request for mesos, Jie Yu, Joris Van Remoortere, and Joseph Wu. > > > Bugs: MESOS-3499 > https://issues.apache.org/jira/browse/MESOS-3499 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 37cfcb732714b61894be4a18e44b6b3d7df554d1 > > Diff: https://reviews.apache.org/r/38667/diff/ > > > Testing > ------- > > ./stout-tests > > > Thanks, > > Artem Harutyunyan > >
