----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100285 -----------------------------------------------------------
src/slave/containerizer/provisioner/docker/store.cpp (lines 210 - 213) <https://reviews.apache.org/r/38137/#comment157441> This can be parallelized right? src/tests/containerizer/provisioner_docker_tests.cpp (lines 737 - 741) <https://reviews.apache.org/r/38137/#comment157487> 4-space indentation. src/tests/containerizer/provisioner_docker_tests.cpp (lines 747 - 749) <https://reviews.apache.org/r/38137/#comment157488> 4-space indentation. src/tests/containerizer/provisioner_docker_tests.cpp (lines 765 - 767) <https://reviews.apache.org/r/38137/#comment157503> 4 space indentation. src/tests/containerizer/provisioner_docker_tests.cpp (line 802) <https://reviews.apache.org/r/38137/#comment157489> s/mesos::internal::// Just because it's way to long and hard on the eyes. :) src/tests/containerizer/provisioner_docker_tests.cpp (line 818) <https://reviews.apache.org/r/38137/#comment157491> s/reference store/metadata manager/ src/tests/containerizer/provisioner_docker_tests.cpp (line 828) <https://reviews.apache.org/r/38137/#comment157490> s/mesos::internal::// src/tests/containerizer/provisioner_docker_tests.cpp (line 841) <https://reviews.apache.org/r/38137/#comment157492> s/reference store/metadata manager/ src/tests/containerizer/provisioner_docker_tests.cpp (line 844) <https://reviews.apache.org/r/38137/#comment157493> s/mesos::internal::// - Jiang Yan Xu On Sept. 22, 2015, 3:15 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38137/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 3:15 p.m.) > > > Review request for mesos, Jie Yu, Jojy Varghese, Till Toenshoff, and Jiang > Yan Xu. > > > Repository: mesos > > > Description > ------- > > Joining all the commits around provisioner and local store into one review so > it's easier to review, as patches > are changing code on top of each other. > > All the commits are going to committed together. > > > Diffs > ----- > > src/Makefile.am e224060 > src/slave/containerizer/provisioner/docker/local_puller.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/local_puller.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/message.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/message.proto PRE-CREATION > src/slave/containerizer/provisioner/docker/metadata_manager.hpp > PRE-CREATION > src/slave/containerizer/provisioner/docker/metadata_manager.cpp > PRE-CREATION > src/slave/containerizer/provisioner/docker/paths.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/paths.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/puller.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/puller.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/store.cpp PRE-CREATION > src/slave/containerizer/provisioner/store.cpp 35d1199 > src/slave/flags.hpp e31a418 > src/slave/flags.cpp add4196 > src/tests/containerizer/provisioner_docker_tests.cpp 1b0c304 > > Diff: https://reviews.apache.org/r/38137/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
