> On Sept. 22, 2015, 11:35 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp, line 68 > > <https://reviews.apache.org/r/38665/diff/1/?file=1082102#file1082102line68> > > > > what's the different between this and os::realpath?
You're right, there is none. I'll drop fs::realpath(). The test is still valid though. - Artem ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38665/#review100150 ----------------------------------------------------------- On Sept. 22, 2015, 11:38 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38665/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 11:38 p.m.) > > > Review request for mesos, Joris Van Remoortere and Joseph Wu. > > > Bugs: MESOS-3499 > https://issues.apache.org/jira/browse/MESOS-3499 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > e64e3d9e958fab3c7c25fad17dcc2b279d255500 > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 76e1674e08bbe65a4fdf86731823a61f231d6d12 > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp > 311b00b41398a9fd7374f3847190468ba59c1dc9 > 3rdparty/libprocess/3rdparty/stout/tests/fs_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38665/diff/ > > > Testing > ------- > > ./stout-tests > > TODO(hartem): Test on OSX (At the time of writing this test the `master` on > OSX was broken). > > > Thanks, > > Artem Harutyunyan > >
