> On Sept. 21, 2015, 4:02 p.m., Adam B wrote: > > Looks good. Do the images still show up when the markdown is rendered on > > the github website?
Unfortunately, no. This change will break the links when you look at them on Github. We can make it work both ways if we remove that trailing `/` on all the documentation URLs. But that means, if someone happens to put a slash on the end, they won't see the images. We should probably document (separately?) that Artem's website container is how we should be previewing the docs now. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38570/#review99857 ----------------------------------------------------------- On Sept. 21, 2015, 2:49 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38570/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 2:49 p.m.) > > > Review request for mesos, Adam B, Artem Harutyunyan, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Also removes extraneous `?raw=true` from the links. > > > Diffs > ----- > > docs/external-containerizer.md 96932189b74dce1ae28e0bd73d5543d1afaffb0b > docs/fetcher-cache-internals.md d17b41e7113ce72679734fc0bed16614011b6917 > docs/maintenance.md 465dcfb72777611c2a4be2aa38c8cd7e869a2baa > docs/oversubscription.md b1a6c9979025ce33190792a07b8e9618c518430e > > Diff: https://reviews.apache.org/r/38570/diff/ > > > Testing > ------- > > Rendered with: https://github.com/mesosphere/mesos-website-container > > Confirmed that images show up on the modified docs. > > > Thanks, > > Joseph Wu > >
