----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38514/#review99710 -----------------------------------------------------------
src/master/http.cpp (line 486) <https://reviews.apache.org/r/38514/#comment156694> this method should be called suppress too. to avoid conflict with the suppress marco, can you try putting that macro inside a "signals" namespace? - Vinod Kone On Sept. 19, 2015, 1:27 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38514/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2015, 1:27 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3037 > https://issues.apache.org/jira/browse/MESOS-3037 > > > Repository: mesos > > > Description > ------- > > A comment from Vinod: After some discussion with other committers, > most of them felt SUPPRESS is better than QUIESCE. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 89ddc10d5873cdf09bf5084c4869bc7c29933eab > include/mesos/v1/scheduler/scheduler.proto > bc19b8dfb2ded26a30a28e7370f06816e0fb1999 > src/master/http.cpp 7cca8b1d3118fe99de79cfaf5360825012d830da > src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27 > src/master/validation.cpp 0f3fc1a20b065a88712cceabab0ceffaec598533 > src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa > src/tests/scheduler_tests.cpp 0f892f9d423f0bc72cdab22452e0ad7965dda444 > > Diff: https://reviews.apache.org/r/38514/diff/ > > > Testing > ------- > > Platform: Ubuntu:14.04 > make > make check > > > Thanks, > > Guangya Liu > >
