----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38475/#review99687 -----------------------------------------------------------
Ship it! src/tests/master_maintenance_tests.cpp (lines 1230 - 1231) <https://reviews.apache.org/r/38475/#comment156666> It seems like we could add an accessor to the master to get a `const` reference to the flags? Want to make a JIRA for this? src/tests/master_maintenance_tests.cpp (lines 1236 - 1237) <https://reviews.apache.org/r/38475/#comment156692> I ran into some non-deterministic behavior repeatedly running this test. Please see the slight changes I made, as well as the subsequent commit to the TestContainerizer. src/tests/master_maintenance_tests.cpp (lines 1261 - 1275) <https://reviews.apache.org/r/38475/#comment156691> Let's make sure both slaves register before we schedule the machine for maintenance mode. - Joris Van Remoortere On Sept. 19, 2015, 6:14 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38475/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2015, 6:14 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3346 > https://issues.apache.org/jira/browse/MESOS-3346 > > > Repository: mesos > > > Description > ------- > > Checks that filters change which inverse offer is sent when. > > > Diffs > ----- > > src/tests/master_maintenance_tests.cpp > 9892bc329ff850f638e9f5e79d047efaf2fcb037 > > Diff: https://reviews.apache.org/r/38475/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
