----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38244/#review99681 -----------------------------------------------------------
Ship it! src/master/allocator/mesos/hierarchical.hpp (line 191) <https://reviews.apache.org/r/38244/#comment156640> I see you adjusted this in a further review. src/master/allocator/mesos/hierarchical.hpp (line 358) <https://reviews.apache.org/r/38244/#comment156641> Why did this get added? It isn't used. Further, this summary suggests we're only doing a rename, when hre we're changing the structure. src/master/allocator/mesos/hierarchical.hpp (line 998) <https://reviews.apache.org/r/38244/#comment156642> See comment above. src/master/allocator/mesos/hierarchical.hpp (lines 1024 - 1029) <https://reviews.apache.org/r/38244/#comment156644> ``OfferFilter`` ``HierarchicalAllocatorProcess::expire`` src/master/allocator/mesos/hierarchical.hpp (line 1302) <https://reviews.apache.org/r/38244/#comment156648> we can add a new line here. src/master/allocator/mesos/hierarchical.hpp (line 1306) <https://reviews.apache.org/r/38244/#comment156649> line wrapping. src/master/allocator/mesos/hierarchical.hpp (line 1308) <https://reviews.apache.org/r/38244/#comment156645> "Filtered offer with " src/master/allocator/mesos/hierarchical.hpp (line 1311) <https://reviews.apache.org/r/38244/#comment156647> we can add a new line here. src/master/allocator/mesos/hierarchical.hpp <https://reviews.apache.org/r/38244/#comment156646> no need to remove this. - Joris Van Remoortere On Sept. 18, 2015, 10:55 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38244/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2015, 10:55 p.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3346 > https://issues.apache.org/jira/browse/MESOS-3346 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 3374d63b8311cf10b3108f56b7b167c12a9d7a37 > > Diff: https://reviews.apache.org/r/38244/diff/ > > > Testing > ------- > > > Thanks, > > Artem Harutyunyan > >
