> On Sept. 15, 2015, 10:10 p.m., Anand Mazumdar wrote: > > include/mesos/executor/executor.proto, line 163 > > <https://reviews.apache.org/r/38278/diff/3/?file=1074517#file1074517line163> > > > > Minor: Can we also have a comment before the `framework_id` field ? > > > > // Identifies the framework which generated this call.
My bad, ignore. I did not see already that the `tuple` (`ExecutorID`, `FrameworkID`) in itself idenfies the executor. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38278/#review99109 ----------------------------------------------------------- On Sept. 15, 2015, 9:32 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38278/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 9:32 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Adding last changes of the executor HTTP API design to the unversioned > protobuf > > > Diffs > ----- > > include/mesos/executor/executor.proto 52c84b3 > > Diff: https://reviews.apache.org/r/38278/diff/ > > > Testing > ------- > > make > > > Thanks, > > Isabel Jimenez > >
