----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review97908 -----------------------------------------------------------
I did not realize that we had a combined RR for this chain - please forgive my ignorance for now - I shall review the combined one once you fixed the locally mentioned issues. src/slave/containerizer/provisioner.cpp (line 45) <https://reviews.apache.org/r/37198/#comment153992> This should fit into 80 chars without a linebreak. src/slave/containerizer/provisioners/docker.hpp (lines 19 - 20) <https://reviews.apache.org/r/37198/#comment153998> I am not sure I like the way this include guard is named as it seems likely to conflict with other docker-related headers. Also we commonly include the extension in that guard (hpp). I would suggest using `__SLAVE_CONTAINERIZER_PROVISIONER_DOCKER_HPP__` or `__MESOS_SLAVE_CONTAINERIZER_PROVISIONER_DOCKER_HPP__` which would strictly follow google's guide. Too bad we never reached a consensus on MESOS-2211 but given that I see potential for a conflict, I would like to ask you to fix this risk no matter which scheme you chose. src/slave/containerizer/provisioners/docker.hpp (line 94) <https://reviews.apache.org/r/37198/#comment154001> The ordering for factory/methods and constructors/destructors is not matching google's styleguide here but given that we are rather inconsistent within the codebase already, I guess I should not start marking those things as issues -- please note but ignore for now :) src/slave/containerizer/provisioners/docker.cpp (lines 182 - 183) <https://reviews.apache.org/r/37198/#comment154004> Fits into a single line. src/slave/containerizer/provisioners/docker.cpp (line 229) <https://reviews.apache.org/r/37198/#comment154005> Why 3 slashes? - Till Toenshoff On Aug. 27, 2015, 11:40 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37198/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:40 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, > Timothy Chen, and Jiang Yan Xu. > > > Bugs: MESOS-2850 > https://issues.apache.org/jira/browse/MESOS-2850 > > > Repository: mesos > > > Description > ------- > > Add Docker image provisioner. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/slave/containerizer/isolators/filesystem/linux.cpp > 4ff1c463efc527e239317ffa2d8a5607b11d2607 > src/slave/containerizer/provisioner.hpp > 541dd4e0b2f0c92a45c00cab6132a2be69654838 > src/slave/containerizer/provisioner.cpp > efc7e6996ff6663bebaf61989a7e040bd2ad7a5e > src/slave/containerizer/provisioners/docker.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker.cpp PRE-CREATION > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > src/tests/containerizer/provisioner.hpp > a26b8138d8cc3086058b15a797dd15354a84019f > > Diff: https://reviews.apache.org/r/37198/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >
