----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37881/#review97015 -----------------------------------------------------------
src/slave/containerizer/provisioner.hpp (line 48) <https://reviews.apache.org/r/37881/#comment152722> Perhaps its worth mentioning if any of the provisioner is failed to create. src/slave/containerizer/provisioner.cpp (line 42) <https://reviews.apache.org/r/37881/#comment152731> I think we should only allow creating the appc provisioner with linux, since I believe most of the appc components requires it right? src/slave/containerizer/provisioner.cpp (line 64) <https://reviews.apache.org/r/37881/#comment152724> This should be provisioners[imageType] src/slave/containerizer/provisioners/appc.cpp (line 106) <https://reviews.apache.org/r/37881/#comment152725> I can't remember, but if the directory exists does it still throw as well? We should assume the directory should be there after recovery? src/slave/containerizer/provisioners/appc.cpp (line 125) <https://reviews.apache.org/r/37881/#comment152726> Why does this not return a Try? We always have a backend specified right? src/slave/containerizer/provisioners/appc.cpp (line 268) <https://reviews.apache.org/r/37881/#comment152727> should be if (!backends.contains(backend)) ? src/slave/containerizer/provisioners/appc.cpp (line 276) <https://reviews.apache.org/r/37881/#comment152728> Ideally we should still log the return value though. src/slave/containerizer/provisioners/appc.cpp (line 358) <https://reviews.apache.org/r/37881/#comment152730> s/by provisioned by/provisioned by/ - Timothy Chen On Aug. 30, 2015, 4:28 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37881/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2015, 4:28 a.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Bugs: MESOS-2796 > https://issues.apache.org/jira/browse/MESOS-2796 > > > Repository: mesos > > > Description > ------- > > Implemented AppcProvisioner. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/slave/containerizer/provisioner.hpp > 541dd4e0b2f0c92a45c00cab6132a2be69654838 > src/slave/containerizer/provisioner.cpp > efc7e6996ff6663bebaf61989a7e040bd2ad7a5e > src/slave/containerizer/provisioners/appc.hpp PRE-CREATION > src/slave/containerizer/provisioners/appc.cpp PRE-CREATION > src/slave/containerizer/provisioners/appc/paths.hpp > 41e3bf79da0854406c488855f953111e67353829 > src/slave/containerizer/provisioners/appc/paths.cpp > 3113c84b9526dd9e9e89fb9aa4ec75ed66a996c7 > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > src/tests/containerizer/appc_provisioner_tests.cpp > 47b66b9c30cefe8f9a8e2c1c1341776c2d235020 > > Diff: https://reviews.apache.org/r/37881/diff/ > > > Testing > ------- > > sudo make check. > > More test cases coming. > > > Thanks, > > Jiang Yan Xu > >
