> On Aug. 26, 2015, 11:05 p.m., Alexander Rukletsov wrote: > > include/mesos/maintenance/maintenance.hpp, line 29 > > <https://reviews.apache.org/r/37314/diff/6/?file=1053339#file1053339line29> > > > > If it's not a protobuf, remove `Info` suffix. The suffix is there only > > to avoid collisions between proto and non-proto classes. Thanks!
This was merged into the new and improved `MachineInfo` protobuf. (Same for your other points :). - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96643 ----------------------------------------------------------- On Aug. 27, 2015, 6:07 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37314/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 6:07 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-3045 > https://issues.apache.org/jira/browse/MESOS-3045 > > > Repository: mesos > > > Description > ------- > > Note: Tests will be added with the related HTTP endpoints and registrar > operations, later in this review chain. > > > Diffs > ----- > > include/mesos/type_utils.hpp 8d27ef439d8bfb30a10b2f32fcd893f0af08ed75 > src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > > Diff: https://reviews.apache.org/r/37314/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
