----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96556 -----------------------------------------------------------
src/slave/containerizer/provisioners/docker/paths.hpp (line 48) <https://reviews.apache.org/r/37497/#comment152057> Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 51) <https://reviews.apache.org/r/37497/#comment152058> Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 56) <https://reviews.apache.org/r/37497/#comment152059> Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 58) <https://reviews.apache.org/r/37497/#comment152060> Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 63) <https://reviews.apache.org/r/37497/#comment152061> Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 69) <https://reviews.apache.org/r/37497/#comment152062> Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 73) <https://reviews.apache.org/r/37497/#comment152063> Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 79) <https://reviews.apache.org/r/37497/#comment152064> Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 84) <https://reviews.apache.org/r/37497/#comment152065> Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.hpp (line 88) <https://reviews.apache.org/r/37497/#comment152066> Kill this blank line please. src/slave/containerizer/provisioners/docker/paths.cpp (line 21) <https://reviews.apache.org/r/37497/#comment152056> This should be the first include. src/slave/containerizer/provisioners/docker/paths.cpp (line 35) <https://reviews.apache.org/r/37497/#comment152049> Just one blank line between these and the others as we stay entirely within the same scope (global) here. src/slave/containerizer/provisioners/docker/paths.cpp (line 48) <https://reviews.apache.org/r/37497/#comment152050> See above. src/slave/containerizer/provisioners/docker/paths.cpp (line 61) <https://reviews.apache.org/r/37497/#comment152051> See above. src/slave/containerizer/provisioners/docker/paths.cpp (line 70) <https://reviews.apache.org/r/37497/#comment152052> See above. src/slave/containerizer/provisioners/docker/paths.cpp (line 85) <https://reviews.apache.org/r/37497/#comment152053> See above. src/slave/containerizer/provisioners/docker/paths.cpp (line 93) <https://reviews.apache.org/r/37497/#comment152054> See above. src/slave/containerizer/provisioners/docker/paths.cpp (line 100) <https://reviews.apache.org/r/37497/#comment152055> See above. src/slave/containerizer/provisioners/docker/reference_store.cpp (line 161) <https://reviews.apache.org/r/37497/#comment152068> Does this break a vital function of Mesos? --> If so, make it a LOG(ERROR) Does this still allow normal function but will disable certain optimizing features? --> If so, make it a LOG(WARNING) Is this valuable information for a user to understand the status of the system? --> If so, make it a LOG(INFO) Anything else is usually a VLOG(1) as it is understandable and useful mostly for developers. - Till Toenshoff On Aug. 25, 2015, 9:03 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37497/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 9:03 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, > and Jiang Yan Xu. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Added Docker provisioner paths which handles path manipulation. > > > Diffs > ----- > > src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab > src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/reference_store.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/37497/diff/ > > > Testing > ------- > > sudo make check > ./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 > --gtest_shuffle=1 > > > Thanks, > > Lily Chen > >
